An improvement to BuildListener #4562

duclong.ng · 1 month ago

BuildListener is already very good with the current functions. But I want to add a few other things.
Current:

...
void buildFinished();
void buildRecommended();
void buildUnRecommended();

Update:

...
void buildFinished();
void buildRecommended();
void buildUnRecommended();
boolean recommendBuild();
boolean unRecommendBuild();

There are several things that need to be done at the same time when a build is recommended and unrecommended. i am using "void buildRecommended();" for that. However, it always returns void and when an error occurs, the build status is still changed to recommended while in fact the related tasks have failed.
@robinshen Can this be applied?

replies 5
views 93
stars 0

robinshen ADMIN · 1 month ago

You may throw exception when there is something wrong and want to prevent build from being recommended/unrecommented.

1 Reply

1 #3

duclong.ng · 2 days ago

Hello@robinshen ,
I threw an exception but it didn't prevent the build from being changed to recommended.
Please check BuildResource.java

build.setStatus(Status.RECOMMENDED);
Context.push(build);
try {
	for (BuildListener listener: PluginManager.instance.getExtensions(BuildListener.class))
		listener.buildRecommended();
} finally {
	Context.pop();
}

Is it possible to add a catch block to revert build status when an exception occurs?

} catch (Exception e) {
	build.setStatus(Status.SUCCESSFUL);
	logger.error(e);
}

How do you think?

robinshen ADMIN · 2 days ago

Are you recommending via restful api. I just add a plugin contributing a BuildListener extension point throwing exception in buildRecommended method, and the restful api call will not change build status from successful to recommended, which is the expected behavior.

BTW: I am testing with QB14

1 Reply

duclong.ng · 1 day ago

"the restful api call will not change build status from successful to recommended"
It doesn't work the same with buttons. Can you make the buttons work like this too?

robinshen ADMIN · 19 hours ago

I see. This will be addressed in next patch release.